search

HeyPuter / puter

🌐 The Internet OS! Free, Open-Source, and Self-Hostable.
https://puter.com
GNU Affero General Public License v3.0
25.53k stars 1.68k forks source link

Setting to change user storage amount #211

Closed KernelDeimos closed 6 months ago

KernelDeimos commented 6 months ago

Self-hosters are not supposed to have a storage limit

I'm pinning this issue because I want everyone to know we're working on it.

The production version of puter (puter.com) has a storage limit for each user. The storage limit is tied into various parts so a little bit of refactoring is needed to remove the limit for self-hosters.

This issue thread will track our progress.

nimit2801 commented 6 months ago

I can pick this up! Let me know if this is something we would want to focus on

AtkinsSJ commented 6 months ago

Likewise, references to getting referrals also don't make a lot of sense when self hosted.

KernelDeimos commented 6 months ago

I can pick this up! Let me know if this is something we would want to focus on

You may, we have a few requirements for this feature that you'll need to keep in mind:

nimit2801 commented 6 months ago

I can pick this up! Let me know if this is something we would want to focus on

You may, we have a few requirements for this feature that you'll need to keep in mind:

* turning on/off storage limits should be a configuration option (default will be off)

* the apparent "storage limit" should appear as the actual capacity of the filesystem Puter is running on for all users when storage limits are off

Interesting case, self host once and will reflect on how to make this option available. Because certainly a users motivation for using this would be to get more space and if that we cannot suffice somewhere we're not giving the freedom to the user. @jelveh could you kindly assign this to me?

KernelDeimos commented 6 months ago

@nimit2801 I added you to assignees. Let me know if at any point you get busy and can't dedicate as much time to this and I'll take over in that case - this is something that's high-priority and I was planning to do myself, but if you're willing to take it on that gives me room to fix some other issues instead.

nimit2801 commented 6 months ago

@nimit2801 I added you to assignees. Let me know if at any point you get busy and can't dedicate as much time to this and I'll take over in that case - this is something that's high-priority and I was planning to do myself, but if you're willing to take it on that gives me room to fix some other issues instead.

Thank you for assigning this to me! I actually related a lot to this bug/issue and that's why wanted to work on this.

nimit2801 commented 6 months ago

image I started development, I'm on my windows machine, but couldn't go beyond this. There is this blank screen, should I change anything else in config?

nimit2801 commented 6 months ago

image I started development, I'm on my windows machine, but couldn't go beyond this. There is this blank screen, should I change anything else in config?

@KernelDeimos any suggestions on how to fix this? is this common issue?

vineeth-vk11 commented 6 months ago

Hey @nimit2801 this is not a common issue. Below points might help.

  1. Make sure you have the latest commits
  2. Check your node version, I am running v20.11.1 and it works fine
  3. Try opening the URL in incognito mode of your browser

If you need help, reach out to me on discord, username - vineethvk11

KernelDeimos commented 6 months ago

Also check the dev console for CORS errors or anything like that. This screenshot is what it looks like when it can load the gui but can't talk to the API. Oh, also maybe Windows doesn't allow subdomains on the localhost domain without configuration; try adding api.puter.localhost manually and please let me know if that turns out to be the issue because if that's the case I need to update the documentation.

KernelDeimos commented 6 months ago

@nimit2801 I merged the fix vineeth contributed, but there are further improvements which can be made: