Heyuri / Uploader

2ちゃん uploader!
MIT License
2 stars 0 forks source link

my branch #11

Closed chen-chan1 closed 5 months ago

chen-chan1 commented 5 months ago

there was not really a discussion page so i will make it as a issue.

i have cleaned up almost all of wart.php some things did get deleted or not been cleaned up. i am to tired to do any of that tonight. give it a look over and test it out. here is the teset server i am running it off of

https://github.com/Heyuri/Uploader/tree/chen-testing http://173.255.204.74/uploader/warota.php

nginx with debian10

this actualy dose use ip adresses. so to hide this. in nginx you would want to make ur own extention .secret and have *.secret be unacssesable from nginx

kaguy4 commented 5 months ago

looks like u did a lot of updates... which I don't understand well ^^;

If it's working well, maybe they can be adapted to our main warota.php. Because seems it's also changed (like addition of config.php) since you started working on the branch

I'm only not sure about the addition of settings for users, I think it's board admins should who should decide on what should be shown about files, depending on the purpose of the board.

chen-chan1 commented 5 months ago

oh well that settings feature was already a thing users can acsses. in the html in the curent state would havenshown users ip in the html if it was enabled

https://up.heyuri.net/warota.php?act=env

kaguy4 commented 5 months ago

oh well that settings feature was already a thing users can acsses.

ah, then we can leave it like that

chen-chan1 commented 5 months ago

and the configs i use are easy to dump and change via a webpage. the hard coded defines not so much.

that forward comparability thing was a huge security risk allowing users to just create globals. and i never ran the original script with error and debugging but the one i got now dose not have any warnings or notices being thrown up.

one thing i can see making this powerful is a board called /cold/ where sysadmin sets up a nfs that just has a ton of storage. and that can go to a users can upload like 2gb at a time. would be slow bc vps to home server but would be it would be hella cheaper to get a terrabyte of storage bc we are cutting out the vps from hosting said files that are uploaded on /cold/

hachikuji-san commented 5 months ago

merging manually now after a few tweaks.

chen-chan1 commented 5 months ago

uwaaaaa!!!!some things like password and deletions i have not tested!!!

kaguy4 commented 5 months ago

yes it doesn't work! I can't delete the ero image off your server now

hachikuji-san commented 5 months ago

he mismatched names in form tags so password would have always been null

hachikuji-san commented 5 months ago

done!