Heyuri / Uploader

2ちゃん uploader!
MIT License
1 stars 0 forks source link

Image preview-like-thing I don't know what I want of #18

Closed kaguy4 closed 2 months ago

kaguy4 commented 2 months ago

might as well make this an issue

Just upload what u had. I have few things I'd be happy if u did: width="250" height="250" < this doesn't need to be square, images should have a CSS class (something like .preview) attached that uses this CSS:

.preview {
    max-height:120px;
    max-width:200px;
    height:auto;
    width:auto;
}

stuff larger than 4*1024*1024= 4194304 bytes shouldn't embed

it should be a cookie setting that's turned off by default

clicking on images will open them in a new tab

hachikuji-san commented 2 months ago

drawing it similarly to how futaba does it is best imho. Though @chen-chan1 if you don't want to for whatever reason then im willing to do it

chen-chan1 commented 2 months ago

ya u can.

hachikuji-san commented 2 months ago

https://up.heyuri.net/src/3431.png

this is about as close as i can get it to look to the futaba uploader userscript without using javascript. Is this ok to push @kaguy4 ?

kaguy4 commented 2 months ago

@hachikuji-san It looks gr8, but I think the "default" thumbnails should be a toggle-able setting in ?goingto=settings like pen initially did

hachikuji-san commented 2 months ago

alright

hachikuji-san commented 2 months ago

preview images can now be toggled on and off. The paging/pagination (no clue what to call it) is fixed in images.php... i forgot one line ^^;

chen-chan1 commented 2 months ago

i already had image preview toggleable that's literally how i showed you the first time since it was off be defualt

https://github.com/Heyuri/Uploader/commit/99723f5ad2790d650cd3b31847a27c3b93092e47#diff-a23a5a294754077df7d72b82374b8f7cc6fc7f0023f25e46c1125b9d677e70d9R189

chen-chan1 commented 2 months ago

there is also a optional to have paging also displayed on the bottom.

hachikuji-san commented 2 months ago

i already had image preview toggleable

That would have been good 2 know, it would have saved... the 5-ish minutes it took to accidentally re-write it. Anywayz there wouldn't have been much point (aside from teh cookie-related parts of code) since the way it's drawn as of now is 1 line. Videos will always be thumbnailed no matter what. Audio will use some default thumbnail. It maeks things simpler.

hachikuji-san commented 2 months ago

settled as for now