search

Heyuri / Uploader

2ちゃん ｕｐｌｏａｄｅｒ！
MIT License
2 stars 0 forks source link

deprecating $denylist #7

Closed hachikuji-san closed 5 months ago

hachikuji-san commented 5 months ago

Since Uploader (we rlly need a better name for it!) doesn't store IP addresses, something like $denylist is completely useless. Though maybe having IP tracking could be an option that could be turned off in config.php? i think it'd be better to remove $denylist entirely, it does unnecessary searches to check if $host is inside the deny list. But $host can only ever be 1337.

kaguy4 commented 5 months ago

Since Uploader (we rlly need a better name for it!)

PHPぁぷろだ is teh Japanese name... We've been calling it 2ちゃん ｕｐｌｏａｄｅｒ！ but I'm up to change it again if we (all users who are interested) come up with a good name.

Though maybe having IP tracking could be an option that could be turned off in config.php?

I think this is a good idea. It should be a setting that can call some module perhaps?

kaguy4 commented 5 months ago

I think just liek antiflood.php config.php should have 2 lines for it:

hachikuji-san commented 5 months ago

$denylist will stay to serve as a ban that blocks the user completely from viewing the uploader at all, which is already a feature. While a new array $banlist along with a new ipcheck module will tell the user they're banned when they try to upload the file (teh upload will fail).

The only "complication" is that when ipcheck is enabled you NEED to hide souko.log or else IPs will leak. Souko.log is already visible on up.heyuri.net, so you can see the passwords people set (also making passwords for user boardz useless).

hachikuji-san commented 5 months ago

also making passwords for user boardz useless

Nevermind, it doesn't store it in souko.log