search

Heyuri / kokonotsuba

Heyuri's BBS software
Other
23 stars 14 forks source link

SWF improvements #135

Open kaguy4 opened 2 months ago

kaguy4 commented 2 months ago

1- SWF files should have their database dimensions displayed next to filesize, just like image files do FIXED!! 2- Kokonotsuba should have a better system for checking dimensions of flash files. When it fails to check, database often logs them as 250x250 px (which comes from MAX_W & MAX_H in config.php - on Flash@Heyuri, I set it to 1000x700 instead for the time being) FIXED!! 3- In thread view, inline expanding them should use the its proper dimensions like fileboards' [Embed] button does

kaguy4 commented 2 months ago

For 2 - I added these functions to lib_common: https://github.com/Heyuri/kokonotsuba/commit/097fb986337008a17540a877114d1ac742667573 but couldn't get them to work on lib_post.php

kaguy4 commented 2 months ago

1 and 3 are left Removing https://github.com/Heyuri/kokonotsuba/blob/main/lib/lib_post.php#L382 solves 1 but it also breaks the thumbnail.

kaguy4 commented 1 month ago

1 is done by https://github.com/Heyuri/kokonotsuba/commit/ceda9b2a5742b47655d464066d961c340e116310

3 is left. Inline expanding SWF files should make the dimensions adjust dimensions of individual flash files instead of fixed 640x480 (unless it would exceed screen port, so it should have some CSS like max-width:100% & max-height:100%) - This is probably a JS thing, I don't know why img.js doesn't already do it

kaguy4 commented 1 month ago

img.js is currently set to just output "<object width="640" height="480">", which ruffle makes use of just removing won't work since it seems to default to 550x400 (the default flash project resolution)

anonwaha edit: (wrap HTML and code in backquotes on here, otherwise all or parts of it won't appear)