search

Heyvaert / wiquery

Automatically exported from code.google.com/p/wiquery
0 stars 0 forks source link

AbstractWiQueryDecoratingHeaderResponse contains incorrect assert #212

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
AbstractWiQueryDecoratingHeaderResponse contains a assert in 
renderJavaScript(CharSequence javascript, String id) which checks if the id is 
not null. The wicket API says the id can be null:

"unique id for the javascript element. This can be null, however in that case 
the ajax header contribution can't detect duplicate script fragments."

This asserts breaks code of the wicketstuff push project which renders 
javascript without an id.

Original issue reported on code.google.com by sven.rie...@topicus.nl on 27 Sep 2011 at 9:25

GoogleCodeExporter commented 9 years ago 
Sorry forgot to mention versions: 

wiquery 1.5.0
wicket 1.5.0
wicketstuff-push-cometd 1.5.0

Original comment by sven.rie...@topicus.nl on 27 Sep 2011 at 9:27

GoogleCodeExporter commented 9 years ago 
fixed in revision 1716.

Original comment by hielke.hoeve on 27 Sep 2011 at 10:24