Heyvaert / wiquery

Automatically exported from code.google.com/p/wiquery
0 stars 0 forks source link

AbstractWiQueryDecoratingHeaderResponse#renderOnEventJavaScript should be aware of IHeaderResponseFilter #250

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. combine WiQueryDecoratingHeaderResponse with 
JavaScriptFilteredIntoFooterHeaderResponse
2. call IHeaderResponse#renderOnLoadJavaScript("...") or 
IHeaderResponse#renderOnDomReadyJavaScript 

What is the expected output? What do you see instead?
'$(document).ready(function(event){...' should be placed into footer bucket 
instead of document's header section

What version of the product are you using? On what operating system?
1.5.6

recommended FIX:

AbstractWiQueryDecoratingHeaderResponse#renderJavaScriptReference( ... ) has to 
call  getRealResponse().renderJavaScriptReference(reference, ...) instead of 
super.renderJavaScriptReference(reference, ...);

additionaly change 
AbstractWiQueryDecoratingHeaderResponse.JavascriptToken#render from 
JavaScriptUtils.writeJavaScript(getResponse(), getValue(), getId());
to
ResourceReferenceAndStringData data = new 
ResourceReferenceAndStringData(getValue(), ResourceType.JS, getId());
            ResourceUtil.renderTo(getRealResponse(), data);

Original issue reported on code.google.com by Michael....@gmail.com on 27 Jun 2012 at 9:31

GoogleCodeExporter commented 9 years ago
The issue was either
-not reproducable
-there is a newer version available
-reported in a version which is no longer supported

if the issue is still present in the latest version (6.9+) then please reopen 
the issue with the required information to reproduce the issue.

Original comment by hielke.hoeve on 26 Nov 2013 at 8:37