search

Heyzap / heyzap-cordova

Heyzap SDK for Apache Cordova
https://www.heyzap.com/
10 stars 18 forks source link

Incorrect event type for banner loaded callback #17

Closed rafaellop closed 7 years ago

rafaellop commented 7 years ago

The "LOADED" type is not what the plugin gets from the SDK. "AVAILABLE" type is the correct one and tested to be working properly.

ekilah commented 7 years ago

This may have been the case before, but looks like it is no longer true, sorry for the confusion:

https://github.com/Heyzap/heyzap-cordova/blob/c8fdc2f9aab4fcdeed0f3f284e6f200c0a45b9d7/src/ios/CDVBasePlugin.m#L135

https://github.com/Heyzap/heyzap-cordova/blob/c8fdc2f9aab4fcdeed0f3f284e6f200c0a45b9d7/src/android/com/heyzap/cordova/ads/CDVListener.java#L57