u/BGGFetcherBot is designed to reply to comments in r/boardgames if the comment includes game names in double brackets with links to the game on BoardGameGeek.com
GNU General Public License v3.0
3
stars
2
forks
source link
[BUG] Lower First Threshold in find_closest_match() #15
Describe the bug
Token sort ratio of 80 or greater might be causing too many false negatives, pushing the closest matches to token set ratio, which will include too many false positives. It seems to be returning the latest expansion in these cases.
Expected behavior
Ideally, the search will find a closer match on the base game or major expansion instead of minor expansion, particularly with long names.
Describe the bug Token sort ratio of 80 or greater might be causing too many false negatives, pushing the closest matches to token set ratio, which will include too many false positives. It seems to be returning the latest expansion in these cases.
To Reproduce https://www.reddit.com/r/boardgames/comments/1320fjt/comment/ji47cpt/?utm_source=reddit&utm_medium=web2x&context=3 https://www.reddit.com/r/boardgames/comments/131hh01/comment/ji1xre6/?utm_source=reddit&utm_medium=web2x&context=3 https://www.reddit.com/r/boardgames/comments/131a31w/comment/ji1qe5v/?utm_source=reddit&utm_medium=web2x&context=3 https://www.reddit.com/r/boardgames/comments/130wy8c/comment/jhybsmy/?utm_source=reddit&utm_medium=web2x&context=3
Expected behavior Ideally, the search will find a closer match on the base game or major expansion instead of minor expansion, particularly with long names.