search

Hi-Folks / milk-sdk-php

Milk SDK PHP is a (fluent) open-source PHP library that makes it easy to integrate your PHP application with location services like Geocode, Route, Isoline, Search Places and Address, location data ...
https://packagist.org/packages/hi-folks/milk-sdk-php
MIT License
7 stars 12 forks source link

Routing V8: Via parameter #52

Closed cgarde89 closed 3 years ago

cgarde89 commented 3 years ago

This will add the parameter via to Routing V8

Addresses issue #46

roberto-butti commented 3 years ago

Ehy @cgarde89 thank you! great implementation! In Routing V8 we achieved 100% full coverage. Would you like to add also test for via parameter ? You could take a look to tests/Here/RestApi/RoutingV8Test.php file , testBasicRouting() method. Let me know if you want to add it.

cgarde89 commented 3 years ago

Ups! my bad. I'm going to write and commit the test for via parameter.

roberto-butti commented 3 years ago

@cgarde89 i see your additional commit. Is it completed on your side ?

cgarde89 commented 3 years ago

@roberto-butti Yes, It is conpleted now