Hi-PACE / hipace

Highly efficient Plasma Accelerator Emulation, quasistatic particle-in-cell code
https://hipace.readthedocs.io
Other
51 stars 14 forks source link

Fix tiling without OMP #1108

Closed AlexanderSinn closed 3 months ago

AlexanderSinn commented 4 months ago

When compiling with -DHiPACE_COMPUTE=NOACC, tiling was turned ON by default leading to incorrect results. This PR fixes tiling and changes the default to off for NOACC.

AlexanderSinn commented 4 months ago

Good point. I enabled the use of tiling again for noacc. However, by default, tiling is off for noacc, as I observed it being slower in a quick test. Before this PR, tiling was broken with noacc and enabled by default.