Improve performance of FFTDirichletFast

AlexanderSinn commented 4 months ago

This PR improves the performence of FFTDirichletFast by combining the GPU kernels between the FFTs into a single kernel. This reduces memory usage by getting rid of the temporary field and increases performance by reducing the memory bandwidth needed (to the temporary field) and reducing kernel launch overhead for small resolutions.

On MI250X with 4095^2 cells, this gives a speed-up of 40%.

[ ] Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
[ ] Tested (describe the tests in the PR description)
[ ] Runs on GPU (basic: the code compiles and run well with the new module)
[ ] Contains an automated test (checksum and/or comparison with theory)
[ ] Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
[ ] Constified (All that can be const is const)
[ ] Code is clean (no unwanted comments, )
[ ] Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
[ ] Proper label and GitHub project, if applicable

MaxThevenet commented 3 months ago

Thanks for this PR! Could you add a short description?

AlexanderSinn commented 3 months ago

It is tested by the GPU CI. I also tested it in a previous commit in the CPU CI which passed (just the doc didn’t work).

Hi-PACE / hipace

Improve performance of FFTDirichletFast #1112