CMake: No Deprecation Warnings

ax3l commented 3 months ago

Setting a cmake_policy to OLD is deprecated by definition and will raise a verbose warning.

[ ] Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
[ ] Tested (describe the tests in the PR description)
[ ] Runs on GPU (basic: the code compiles and run well with the new module)
[ ] Contains an automated test (checksum and/or comparison with theory)
[ ] Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
[ ] Constified (All that can be const is const)
[ ] Code is clean (no unwanted comments, )
[ ] Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
[ ] Proper label and GitHub project, if applicable

AlexanderSinn commented 3 months ago

This just disables the warning, right? Can we use the NEW policy instead?

ax3l commented 3 months ago

Yes, I need to work down from AMReX and bump the CMake requirements to 3.24+, so we can continue to use native for CUDA_ARCHITECTURES defaults without breaking the current logic. I delayed this a bit so that CMake release is widely used and tested (we are now at 3.29, so we can take it on). https://cmake.org/cmake/help/latest/prop_tgt/CUDA_ARCHITECTURES.html

Hi-PACE / hipace

CMake: No Deprecation Warnings #1118