Hi-Ray / infinityedge

An automation wrapper around stormrazor
GNU General Public License v3.0
2 stars 0 forks source link

[BUG and SUGGESTION] About the Riot Assets and various things #4

Closed Neinndall closed 1 year ago

Neinndall commented 1 year ago

Describe the bug + Suggestion From what I see, it doesn't seem to download anything from the AU "Cupcakes 4 Heartaches" event (test). In addition, it does not find the event (lunar) currently, in the previous version it downloaded the assets without problems. However, in "AU" there is the lunar event and it still does not download it. Below, I propose an idea of if it could be done.

image image

On the other hand, I don't know if changing "lc_home_en_US.json" to "lc_home_en_AU.json" will affect the arrival and detection of events in one region to another. I don't know if there will be an opportunity to do one thing in the tool:

image Infinite seems to prioritize the download of the first images and not the videos and the following images from "game_library" "product_details" as I said, the first image is the same but it is the cut image. The other .json, the same thing happens.

To Reproduce Steps to reproduce the behaviour: I run the program, it detects the (AU) event but in the end it doesn't download any asset and either the LUNAR EVENT. image There is no asset inside the event? Is rare.

Expected behaviour Find assets (someone)

Screenshots Added.

Desktop (please complete the following information):

Additional context No.

Hi-Ray commented 1 year ago

For the cupcakes event as mentioned on discord I discussed this with @bangingheads and we have agreed to manually pull these assets as the tools required would make it difficult to maintain infinityedge.

Hi-Ray commented 1 year ago

As for the assets missing from the riot client the current iteration is still experimental and will improve over time.

With that mentioned thank you for the bug report I will look into it.

Neinndall commented 1 year ago

image

and the other thing about "lc_home_en_US.json" change to "lc_home_en_AU.json" to detect events in the AU region?

image Currently is not detected the lunar event, when that event is active in AU, i explain? If infinite is taking the AU manifest it is not downloading the assets of the active lunar event.

It is from what I was saying, I don't know if a small adjustment can be implemented which, that InfiniteEdge is mainly based on "https://lolstatic-a.akamaihd.net/lc-home-config/v1/live/lc_home_en_US.json " and also check "lc_home_en_AU" in case infinite find an event that is not in "US"

Hi-Ray commented 1 year ago

Like I said previously these events we will manually upload to universe on CommunityDragon. As for the checking of the AU locale it wouldn't really benefit us afaik. If this changes in the future we can re-evaluate it then in which case I would advise opening another issue for this entirely.

Hi-Ray commented 1 year ago

As of 93d958e the fetching for all assets should be fixed if any more issues arise please reopen the issue but for now I am closing this issue