search

HiDeoo / starlight-blog

Starlight plugin to add a blog to your documentation
https://starlight-blog-docs.vercel.app
MIT License
159 stars 21 forks source link

feat: clarify astro 4 compatibility #21

Closed levino closed 9 months ago

levino commented 11 months ago

Describe the pull request

I updated the dev dependency to astro to version 4.

Why

We should test the code with the current version of astro, because this is what users will probably use.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starlight-blog-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 8:52am
levino commented 11 months ago

@HiDeoo You could relax the requirements for the workflows to run on forks. There is something like "New contributors new to github". I am not new to github :)

levino commented 11 months ago

The tests also pass with starlight@0.13. This is also in line with what you said before @HiDeoo. I added d7ef622b465a75aef01d774d46a4586547682e83 to reflect this fact.