vercel[bot]
commented
4 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| starlight-blog-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 2, 2024 2:54pm |
Note: I did not bother creating an issue for this, considering the simplicity of the change.
Describe the pull request
This PR suggests updating the Guide > Authors examples to specify the size of the GitHub avatars to 200x200, as it is the case for the live examples at demo blog.
Context
By default, a GitHub avatar image can be pretty big; https://avatars.githubusercontent.com/u/10137 is for example a 460x460 image that weighs around 300kB. For the ghost image (https://avatars.githubusercontent.com/u/10137), it's lower and only 16kB. So it will depend on the image.
In the demo blog, we can see that these images are rendered next to the authors' information in small.
When not zoomed, TBH, the rendering is almost the same. When zoomed, at 48x48, it's pretty blurry, and we can feel the difference between 96x96 and 200x200. And between 200x200 and 460x460 (default), you must zoom even more to see the difference, IMHO.
Based on these elements, your choice in the different examples seems to be pretty good one as it already saves some kBs.
Why
So the examples in demo blog use a good size, but this good practice is not reflected into the documentation at Guide > Authors where no size is set when using GitHub avatars.
However, this is maybe on purpose in order to avoid adding complexity to the main point of this page, which is to configure the authors.
I let you decide if it is worth a change or not, feel free to close this PR directly if this change is not a good idea or for any other reasons :)