search

HiDeoo / starlight-blog

Starlight plugin to add a blog to your documentation
https://starlight-blog-docs.vercel.app
MIT License
159 stars 21 forks source link

Change Separation Character #76

Closed trueberryless closed 3 months ago

trueberryless commented 3 months ago

Describe the pull request

If @HiDeoo wants to adapt the separation character from - to • like I mentioned in #72 I changed the code necessarily...

Why

See the discussion above.

How

Only changes made in Metadata.astro.

Screenshots

image

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starlight-blog-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2024 10:50am
HiDeoo commented 3 months ago

Thanks for the pull request.

This change has an unintended side effect as screen readers will read this character so instead of getting "Last update" like before:

https://github.com/user-attachments/assets/7f9e0a64-ac17-4af5-8142-b16bc378066c

This would now read as "bullet last update" which is not ideal:

https://github.com/user-attachments/assets/ea036ab0-450c-436a-b60b-facae7e21f62

I don't think the change is worth trying to workaround screen readers in this specific case so I'll close this pull request. Thanks for the contribution though!