search

HiDeoo / starlight-openapi

Starlight plugin to generate documentation from OpenAPI/Swagger specifications
https://starlight-openapi.vercel.app
MIT License
107 stars 13 forks source link

Update dependencies to use NPM for @astropub/md #15

Closed keturiosakys closed 8 months ago

keturiosakys commented 9 months ago

Describe the pull request

Why

When installing the package with Yarn, it fails to resolve gitpkg link in the @astropub/md dependency. Apparently that's due to Yarn likely not being able to resolve query params.

How

Looks like the necessary changes are already published in the NPM version of the package, so this small update replaces the gitpkg link with an NPM link.

Screenshots

Not applicable

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starlight-openapi ❌ Failed (Inspect) Dec 11, 2023 2:58pm
HiDeoo commented 8 months ago

My apologies, this PR totally slipped through my notifications and I randomly saw it today while fixing unrelated issues in another branch.

As I was in the process of fixing other issues preventing to build this PR and in order to get this out quickly, I've used your fix in my branch and co-authored it with you.

This should be now fixed in v0.4.0 that I've just released.

keturiosakys commented 8 months ago

No worries, at all and thanks for all your work on this! Just FYI, I've merged a new update to the @astropub/md that's in v0.4.0 dependency that will make it work with Astro 4: https://github.com/astro-community/md/pull/11

HiDeoo commented 8 months ago

Just FYI, I've merged a new update to the @astropub/md that's in v0.4.0 dependency that will make it work with Astro 4: astro-community/md#11

Wow, that's an amazing news, thanks a lot. This means that when the upstream Starlight issue preventing the update is fixed, we won't hit again this Yarn issue by just using v0.4.0 🎉

Note: it looks like something is wrong with the https://github.com/astro-community/md repo as it now contains the content of the https://github.com/astro-community/context repo. I'll open an issue.