search

HiEventsDev / Hi.Events

Open-source event management and ticket selling platform. Perfect for concerts, conferences, and everything in between 🎟️
https://hi.events
Other
1.89k stars 145 forks source link

Fix startup.sh not found when building on Windows #31

Closed NelsonDane closed 3 months ago

NelsonDane commented 3 months ago

This small PR fixes startup.sh file not being found in when building on Windows (Fixes https://github.com/HiEventsDev/hi.events/issues/5 and Reddit comment)

The reason that this was occurring is because Windows saves the file with Windows line endings instead of the Unix line endings required by the Docker container. This is easily remedied by running dos2unix in the Dockerfile so that it doesn't need to be changed manually when building on Windows.

daveearley commented 3 months ago

Thanks for this @NelsonDane!