HiFaraz / node-playbook

Get started fast with Node.js
http://nodeplaybook.com
1.39k stars 31 forks source link

Switch to more common naming conventions #28

Closed antony closed 8 years ago

antony commented 8 years ago

'src' is almost universally used, I've never seen any project use 'source' Creating a build output dir is unnecessary - any module creating output should remove and recreate this dir as and when it needs to. Additionally, production code should probably end up in a directory called 'dist', another common convention.

FlorianWendelborn commented 8 years ago

Meanwhile I use source exclusively, since I think it's kind of weird to abbreviate a word that short and descriptive. I do agree with build being unnecessary though, at least for non-library projects (and arguably even for libraries).

Why would you distinguish between dist and build though? I think the difference is entirely which git commit you're viewing.

HiFaraz commented 8 years ago

Thanks for this!

I personally use source for the same reasons as @dodekeract, but I think that the playbook should teach the convention.

Please submit a PR to remove the line about the build folder too.

HiFaraz commented 8 years ago

Oops, just realized that this already takes out the build folder line too. Awesome!