search

HiFi-LoFi / KlangFalter

Convolution audio plugin (e.g. for usage as convolution reverb)
GNU General Public License v3.0
168 stars 35 forks source link

4 channels IR files do not work anymore #3

Open falkTX opened 11 years ago

falkTX commented 11 years ago

4 channels IR files used to work, but they don't anymore.

I believe either this https://github.com/HiFi-LoFi/KlangFalter/commit/03fe8063c26cb94270ffdf1407d57ee4869f00ec or this https://github.com/HiFi-LoFi/KlangFalter/commit/d2c01c93f1ca2f4cf5865ca481c750dbdf75f412 introduced the regression.

A test case are these free IR files: http://www.samplicity.com/bricasti-m7-impulse-responses/ The generic wav files work fine, the quad ones do not.

HiFi-LoFi commented 11 years ago

Hi falkTX,

thanks for reporting!

I just tried to reproduce it on my computer, but here it worked perfectly fine. :-(

In the changes you mentioned, I added additional support for FFTW. Which FFT do you use? The default is OouraFFT which shouldn't have changed. However, if the FFT were wrong, then I'd expect that the convolver doesn't work at all, but you described that the regular stereo case works as expected.

Can you explain a little bit more detailed, what's not working anymore with 4-channel IR files. Does the plugin crash, or isn't there no reverb sound anymore or something like this?

In the non-working 4-channel case, do you know whether already loading of the IRs fails? Are waveforms for all channels displayed in the UI?

Which version of Juce do you use? I'm here still on a little dated version of Juce (2.0.32). Maybe I have to do some adaptions for the current version.

Maybe I should update the KlangFalter to the latest Juce version (maybe this also helps with issue #2).

Thank you so much for your efforts! :-)

Regards, Uli

falkTX commented 11 years ago

Hi there. I'm using a very recent juce tip, just from some days ago. Making your plugin work with latest juce is very welcome, as that will make distrho version diff smaller.

The issue with 4 channels seems to be that the wav files are not read correctly. and... it seems to be working fine again now, errr. I'll make more tests and report back.

HiFi-LoFi commented 11 years ago

Hi,

I've updated KlangFalter now to the current head of Juce (which is at the moment 42aa27900b49ba75b5a2f15926256307c566c11a). I've also tried to include your changes regarding the settings directory on Linux, so I hope there shouldn't be much diff anymore between this and DISTHRO's version of KlangFalter. :-)

Regarding the 4-channel IRs, anything new here? I also did some testing but everything seems to work fine (but on Mac, because I don't have a Linux system at hand at the moment).

Greetings, Uli

DoosC commented 11 years ago

Hello, I just came to have the exact same issue as above with 4-channel IRs. I'm am running it on Linux also. The issue is always the same : 2 channels files load just fine but 4 channels are failing to load for some months now. Unlike falkTX the issue is still here even with the latest updates. I was about to give up on KlangFalter because the situation has not improved for weeks but he suggested me to report here. So here I am ;) It used to work but not anymore (it seems to stop working 2 months ago). I used the same test files as mentionned above (Wave quad channel files, 32 bit, 48 Khz). 1-1 and 1-2 appear to load fine. But 2-1 and 2-2 load blank. The output sound is balanced mostly on one side. kf1 kf3 kf4 kf2