search

HiFiLES / HiFiLES-solver

High Fidelity Large Eddy Simulation Solver
Other
172 stars 131 forks source link

The position of "send_sgsf_fpts" in the "CalcResidual" method #86

Closed bizhishui closed 9 years ago

bizhishui commented 9 years ago

Hi all, I've a question about the position of the method "send_sgsf_fpts" in the CalcResidual. In the current code, the send function appears before the method "evaluate_sgsFlux"! Why? I think it should locate between "evaluate_sgsFlux" and "receive_sgsf_fpts".

Thanks for your comments.

Best regards, Maixme

jrbull commented 9 years ago

Maxime, I think you are right - this is a bug, although it may not show up in any significant way in simulation results. Thanks for bringing this to our attention. Regards, Jonathan Postdoctoral Scholar Dept of Aero/Astro Engineering Stanford University

On Aug 1, 2015, at 4:35 PM, jmaximelv notifications@github.com wrote:

Hi all, I've a question about the position of the method "send_sgsf_fpts" in the CalcResidual. In the current code, the send function appears before the method "evaluate_sgsFlux"! Why? I think it should locate between "evaluate_sgsFlux" and "receive_sgsf_fpts".

Thanks for your comments.

Best regards, Maixme

— Reply to this email directly or view it on GitHub.