search

HiLleywyn / Extras

OTClientV8 Modules for Evolunia (Created by Tether on Evolunia)
https://evolunia.net/
The Unlicense
1 stars 1 forks source link

mana() won't work properly when using !percentage #4

Closed Kezuino closed 2 years ago

Kezuino commented 2 years ago

To correctly display health/mana and since the protocol limits the health and mana to be 65535 at maximum (uint16), some players use !percentage to display health/mana in percentages instead of values. This does however also affect the current health, current mana ,max health and max mana to be in percentages instead of the actual value. This also means that mana() will return the current mana in percentages and calculating cost will no longer work properly.

https://github.com/EvoluniaCommunity/OTClientV8-Modules/blob/62460fda8ebeb98408b0cab49815a949fd969330/game_bot/default_configs/WoofTools/Core/Heals/Heals.Conditions.lua#L188

HiLleywyn commented 2 years ago

Removed the conditions manager for now. It seems with this issue, it'll cause the client to slowly lag more and more until it's nearly unusable, causing deaths in cavebot. -- Will look for a fix.

HiLleywyn commented 2 years ago

I figured the easiest / safest route here is to remove the check for mana since it's negligible in Evolunia.

It's running this way on the 2.2.0 branch currently.

A separate issue with this same tool is the isBurning() portion, which throws errors in the console if looking for the condition.

HiLleywyn commented 2 years ago

Fixed in v2.2.0