HiPhish / info.vim

Browse info files from Vim (mirror)
https://gitlab.com/HiPhish/info.vim
MIT License
41 stars 6 forks source link

going to a specific node in the file with tab-completion #14

Open loyalpartner opened 5 months ago

HiPhish commented 5 months ago

I'm currently busy, so I cannot review the PR fully. Feel free to bump this PR if I don't respond by the middle of next week.

HiPhish commented 5 months ago

I like your idea of using --subnodes, but parsing the menu entries is too fragile, it gives wrong entries like * Menu: and some entries contain extra text like * The 'trap' builtin (*note Bourne Shell Builtins::.

How about we instead parse the top line of every node? It already contains the full canonical name of the node, so we only have to pick out that part. I have pushed the changes, tell me what you think.

I also added back the --node option in s:encodeCommand, otherwise jumping to a node would not work for me.

Let me know if you have any comments, otherwise please squash the commits and force-push so that I can merge.