search

HiPhish / jinja.vim

Filetype detection an syntax support for Jinja templates.
Other
24 stars 5 forks source link

Added common jinja extensions to ftdetect #1

Closed rubentsirunyan closed 5 years ago

rubentsirunyan commented 5 years ago

Detection of files with *.jinja and *.j2 extensions has been added.

HiPhish commented 5 years ago

Looks good, but is there precedent out there for these file extensions? As far as I know there is no canonical extension recommended by the authors of Jinja.

Also, can you please open the pull request on GitLab instead? That's what I use for development, this is just a mirror. If not that's OK, we can finish discussion here and I'll merge it manually over there.

https://gitlab.com/HiPhish/jinja.vim

rubentsirunyan commented 5 years ago

@HiPhish, yes, I guess there is no specific extension recommended by jinja.

.j2 is the recommended extension by Ansible and .jinja2 by PyCharm if I am not mistaken.

No problem, we can finish the discussion here and I'll open a PR in GitLab.

HiPhish commented 5 years ago

Thank you, merged the code on GitLab. This issue can be closed now.