HiPhish / rainbow-delimiters.nvim

Rainbow delimiters for Neovim with Tree-sitter
https://gitlab.com/HiPhish/rainbow-delimiters.nvim
Apache License 2.0
532 stars 39 forks source link

Update julia queries #107

Closed mehalter closed 5 months ago

mehalter commented 5 months ago

the Julia treesitter did a huge breaking change refactor recently that is now available in nvim-treesitter that breaks this plugin. There is no longer a parameter_list and the elements that were identified with parameter_list are now just argument_lists. So we can simply remove this query.

This also adds a couple missing queries for tuple expressions and curly brace expressions

Relevant PRs:

HiPhish commented 5 months ago

Thank you. Can you please update test test file (test/highlight/julia/regular.jl) as well? There are no examples of tuple_expression and curly_expression.

mehalter commented 5 months ago

Yeah definitely @HiPhish ! I went ahead and updated the test/highlight/julia/regular.jl file to have examples of both a tuple_expression and a curly_expression

HiPhish commented 5 months ago

Thanks. Can you please squash the two commits? The second commit does not make sense without the first one, and the Git history would be cleaner.

mehalter commented 5 months ago

Sure thing. I just squashed the commits. I was thinking the commits were separate since one fixed a bug that was introduced when queries were removed upstream and then the other commit added in queries that were missing regardless of the changes upstream.

Thanks! Looking forward to this getting merged in :)

HiPhish commented 5 months ago

Merged, thank you.