search

HiPhish / rainbow-delimiters.nvim

Rainbow delimiters for Neovim with Tree-sitter
https://gitlab.com/HiPhish/rainbow-delimiters.nvim
Apache License 2.0
465 stars 34 forks source link

fix: type and checkhealth updates #79

Closed Danielkonge closed 6 months ago

Danielkonge commented 6 months ago

I did a :checkhealth today and noticed a problem with rainbow-delimiters, it seems that the health check wasn't updated with the recent updates. In this PR I updated the health file with something that should work with the recent updates.

While doing this I noticed that the types for priorities allowed the function to return nil, but I don't think we ever want that. (For strategies we allow a function return of nil to disable rainbow-delimiters for the given language, but for queries and priority it doesn't really make sense to allow nil. Unless you again want to use this for something?)

HiPhish commented 6 months ago

While doing this I noticed that the types for priorities allowed the function to return nil, but I don't think we ever want that.

You are right, that was a mistake.

HiPhish commented 6 months ago

Everything looks good now. Please squash and I will merge.

Danielkonge commented 6 months ago

Everything looks good now. Please squash and I will merge.

I have squashed the commits now.

HiPhish commented 6 months ago

Merged, thank you.