search

Hibeom0929 / pe

0 stars 0 forks source link

Reservation is not logical #9

Open Hibeom0929 opened 5 months ago

Hibeom0929 commented 5 months ago

Currently, if the I want to take notes about reservations, I should use the index of contacts which contains not only the name and phone number but also the email and address to add reservations. However, it is very strange that the restaurant owners have the customer's real address and email address. Also, they may not save all the customers' contact information privately. Thus, it would be better

  1. make address and email optional(or maybe not optional only for employee and supplier)
  2. can use "rsv" command with name, phone number, d, t, p, like add instead of using the already saved contacts by using index.
nus-pe-script commented 5 months ago

Team's Response

This was already captured in our planned enhancements.

image.png

Having less compulsory fields makes it much easier to add a contact. This in turn makes it easier to make a reservation for a contact, without requiring the customer's real address and email address like the reviewer has suggested.

Reviewer's second suggestion is a fundamental change to the functionality of the rsv command, and is not relevant to our feature.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree that my first suggestion is mentioned in the planned enhancement. But I think my second suggestion is relevant to your feature. I'm not saying to delete the current logic of rsv, but enable the user can add reservations not only by the index but also by the exact name for convenience (As the user doesn't need to save contact first and then make the reservation if it is implemented). So, I think it is not response.Rejected but response.NotInScope.