search

HibiscusMC / HMCCosmetics

The all-in-one cosmetics solution created by HibiscusMC Team, for HibiscusMC.
https://docs.hibiscusmc.com/
GNU General Public License v3.0
115 stars 51 forks source link

[Bug] Cosmetics not hiding immediately upon player-death #126

Open Boy0000 opened 1 year ago

Boy0000 commented 1 year ago

Plugin Version

2.6.5-DEV

Server Version

git-Paper-196 (MC: 1.20.1)

Issue description

When a player wearing a backpack dies, it does not immediatly hide/despawn the backpack Seems to either do so on respawn or it teleports the entity to player on respawn

Steps to reproduce

  1. Equip backpack
  2. Die
  3. :)

Issue priority

Low (slightly annoying)

Other Versions

Just saw Settings.unapply-on-death but it doesnt seem to fix it

https://github.com/HibiscusMC/HMCCosmetics/assets/62521371/76c50fd8-d71d-45a0-a2f3-0cb5999e5d3f

LoJoSho commented 1 year ago

This was intensional because the armor stands for backpacks were actual entities at one time, leading to the problem of despawning/respawning for backpacks. Nowadays, since it's all packets, it wouldn't be that much of a problem to do spawning/despawning of the backpacks when someone dies. I'll look into this!

MiguVT commented 2 months ago

any update about it?? it got fixed?

LoJoSho commented 2 months ago

No, the issue still isn't fixed, hence why it's still open.