HibiscusMC / HMCCosmetics

The all-in-one cosmetics solution created by HibiscusMC Team, for HibiscusMC.
https://docs.hibiscusmc.com/
GNU General Public License v3.0
115 stars 50 forks source link

[FEATURE] Cosmetics showing in emotes, free camera and movement during emotes, and multiple cosmetics per slot #68

Open D-Captain-TE opened 1 year ago

D-Captain-TE commented 1 year ago

I have checked that...

Description

When emoting, it should be possible to attach the cosmetics the player is currently wearing to the animation. You have extra bones in the animation file that hold the backpack, hat, offhand, and armor which you can animate accordingly. That way, the rotations and positions of the armor stands can be adjusted accordingly.

That being said, it should also be possible to move around during the emote as well as have a free camera, I imagine you might only have to rotate the model of the player by the y axis using the yaw value.

I would also like to suggest letting players equip multiple cosmetics per slot set by a config option.

Config Changes

free-camera: true backpack-slots: 3 hat-slots: 3

D-Captain-TE commented 1 year ago

addendum: whatever is in the player's hand can also be shown

LoJoSho commented 1 year ago

I can definitely look into figuring that out in PlayerAnimator. As for free movement while in the emote, that's something that will require reworking how it currently works.

D-Captain-TE commented 1 year ago

image

Does this mean you're starting to figure out free movement or you have figured it out and I missed smth in the code? I've been looking at your guys' code to see if I can help with an implementation plan for cosmetics in emotes.

LoJoSho commented 1 year ago

That was more of a TODO comment in case I ever got around to that section of code again.

LoJoSho commented 1 year ago

I just noticed that you also added "multiple cosmetics per slot". Do not continue to pile onto the same issue with completely different issues. Open a new issue.

Furthermore, multiple cosmetics per slot would require significant reworking internally as the plugin assumes one cosmetic per slot. I don't even know how the plugin would show multiple cosmetics per slot (like, how would a player have 3 different leggings shown at the same time?)