HibiscusMC / HMCLeaves

https://polymart.org/resource/hmcleaves.3136
GNU General Public License v3.0
12 stars 8 forks source link

[SUGGESTION] Make us able to decide the drop of breaking vines #20

Open MarkinhosMLP opened 1 year ago

MarkinhosMLP commented 1 year ago

leaf-drop-replacement option but for vines

Fisher2911 commented 1 year ago

It should already drop the item, is it not doing that?

MarkinhosMLP commented 1 year ago

It should already drop the item, is it not doing that?

nope... tried for cave vines, weeping vines and also twisting vines

havent tested for other stuff, except for leaves which i know its working fine and for logs i use oraxen integration, so works with itself

Fisher2911 commented 1 year ago

Are you breaking the vines with shears?

MarkinhosMLP commented 1 year ago

Are you breaking the vines with shears?

yes, but i couldnt get it also, when i break without shears, if it is weeping or twisting vines, it will drop the vanilla item

Fisher2911 commented 1 year ago

Can you send a video of what happens?

MarkinhosMLP commented 1 year ago

Can you send a video of what happens?

i updated the plugin to see if it was fixed, also to enjoy the new features but seems like the blockstates are not updating, so the vines are not working Dx

https://github.com/HibiscusMC/HMCLeaves/assets/47507632/71c8f6bb-e7b1-4ff4-9386-7960f6b3109c

MarkinhosMLP commented 1 year ago

also, sometimes it drops the vanilla glow berry instead of the custom berry, which shouldnt be happening lol, i think it is because the block is set to cave_vines_plant, maybe a conflict with the #21 fix

https://youtu.be/qFbwQDtQ8x8

Fisher2911 commented 1 year ago

I think there's something messed up in your config, I haven't come across this issue but I'll do some testing later

MarkinhosMLP commented 1 year ago

I think there's something messed up in your config, I haven't come across this issue but I'll do some testing later

here is my config

cave-vines:
  sculk_vine_item:
    with-glow-berry-id: sculk_vine_berry
    state-id: 2
    tipped-state-id: 3
    should-grow-berries: true
    glow_berry: sculk_berry
  sculk_vine_berry:
    state-id: 4
    tipped-state-id: 5
    should-grow-berries: true
    glow_berry: sculk_berry
MarkinhosMLP commented 1 year ago

i also tried this

cave-vines:
  sculk_vine_item:
    with-glow-berry-id: 4
    state-id: 2
    tipped-state-id: 3
    should-grow-berries: true
    glow_berry: sculk_berry

and this

cave-vines:
  sculk_vine_item:
    with-glow-berry-id: sculk_vine_berry
    state-id: 2
    tipped-state-id: 3
    should-grow-berries: true
    glow_berry: sculk_berry
MarkinhosMLP commented 1 year ago

any updates or info about this?