[Suggestion] Compatibility with Nova

[AllayBreeze]

Currently only the leaves' drops can be changed, and if set to leaf-drop-replacement: [], it'll drop vanilla leaves instead of not drop anything. Other kinds of blocks seems just unable to change/disable the drops. I'm currently using another plugin (neither IA nor Oraxen) to manage custom items, so I hope there can be a configuration that can really change/disable the drops of blocks, so that I can totally remove the drops of all kinds of blocks.

[Fisher2911]

Why do you want to disable the drops of blocks?

[AllayBreeze]

To make all blocks not drop anything so that I can manually set up drops that I need from the custom item plugin. Currently I have made some tricks to cancel the item entity spawning to disable drops. Though it would still be better if HMCLeaves has configurations that can directly set the drops to empty (reducing server calculations, etc.). I think this should be one of the basic degrees of freedom required for a custom item plugin, as others like ItemsAdder or Oraxen can certainly do this.

[Fisher2911]

What custom item plugin are you using?

[AllayBreeze]

https://github.com/xenondevs/Nova It's spigot link seems to have some problems (https://www.spigotmc.org/resources/nova-%E2%9C%A8-custom-blocks-%E2%9C%85-items-%E2%9C%85-guis-%E2%9C%85-modding-framework-fully-configurable-1-19-1-1-19-2.93648/)

[Fisher2911]

I can add support for it so you can use Nova items in the config, does that work for you?

[AllayBreeze]

Hmm, that'll also be good if you can directly add compatibility with it. It's nice too.

[AllayBreeze]

This Nova plugin also has some other incompatibilities with HMCLeaves, besides the leaves dropping vanilla item issue (#24), it also makes axes unable to break anything except wooden blocks

[Fisher2911]

Can you send a video of what you mean?

[AllayBreeze]

https://github.com/HibiscusMC/HMCLeaves/assets/108282297/39a6ac71-2ea5-4fac-b3c5-0fbb6689aaa1

https://github.com/HibiscusMC/HMCLeaves/assets/108282297/aa6b9fcb-01b8-46cf-9fed-7ea2a3be3639

Like this. When HMCLeaves and Nova are both installed, the axe cannot break blocks that are not log or wood (snow layer & grass block in video), and custom leaves drop oak leaves when broken with shears. About the first issue, as I know Nova is also using the mining fatigue effect to achieve the block hardness effect, which might conflict with HMCLeaves. About the second, currently I don't know what is most likely causing that (maybe because Nova overrides the loot table of vanilla leaves, but not sure about that)

[Fisher2911]

And these issues don't happen when Nova isn't on the server?

[AllayBreeze]

Yes, only happen when both plugins are installed

[Fisher2911]

It seems like that is a Nova issue then, I haven't experience the issue when using Oraxen or ItemsAdder

[AllayBreeze]

Yes but it should work fine when only use Nova. Maybe the way Nova uses mining fatigue is different from IA and Oraxen If it's too hard to solve the axe issue, could you just add a configuration that can disable the block hardness system of HMCLeaves? This is now a bit thorny for me as custom axes made of Nova also have issues and cannot be normally used. (an example is the Star Axe in nova's official Machines addon)

[Fisher2911]

This is something Nova should fix, they shouldn't be trying to handle custom mining unless it's a Nova block.

[AllayBreeze]

Maybe not...Nova can also be used to create custom tools and define the breaking speeds of them, which should make use of all kinds of blocks.