Closed dependabot[bot] closed 1 month ago
@JFriel Not actually an issue with this package/update, but we have an issue in the RemoteAttacher date logic regarding timezones - it's calculating with local time rather than UTC, and what that timezone is depends on the server in question. Ideally need to switch the date handling in RemoteAttacher to use UTC for everything (DateTime.UtcNow
not DateTime.Now
in C#, GETUTCDATE()
not GETDATE()
on MS SQL, UTC_DATE()
not DATE()
on Oracle...)
This means CI occasionally fails depending on the time of day - the Github VMs are on Pacific time IIRC, so about one-third of the time the local date is a day behind the UTC date, causing an off-by-one which breaks those unit tests.
Not the first bit of RDMP to hit this; there's some older code that spent a while with a "Do not run this test late at night" label on it since it would fail for similar reasons between 11pm and midnight UK time six months of the year...
Bumps Microsoft.NET.Test.Sdk from 17.9.0 to 17.10.0.
Release notes
Sourced from Microsoft.NET.Test.Sdk's releases.
... (truncated)
Commits
83d73f7
Merge branch 'rel/17.10' of https://github.com/microsoft/vstest into rel/17.10d170364
Prebuilds that are allowed on main2eaee54
Update dependencies from https://github.com/dotnet/arcade build 20240520.3 (#...238626a
Touch 17.10 (#5051)cd5cc85
Update arcade25f10aa
Merge branch 'rel/17.10' of https://github.com/microsoft/vstest into rel/17.103d869ea
Remove pt4990482
[rel/17.10] Add list of known TestingPlatform dlls (#4982)56d2884
Disable CA2022 errors (#4961)1cd0d89
Brand as releaseDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show