search

HicServices / RDMP

Research Data Management Platform (RDMP) is an open source application for the loading,linking,anonymisation and extraction of datasets stored in relational databases.
https://github.com/HicServices/RDMP#research-data-management-platform
GNU General Public License v3.0
36 stars 16 forks source link

Permission Window Midnight [Thomas] #707

Open RoyMudie opened 2 years ago

RoyMudie commented 2 years ago

Setting a permission window of 18:25-00:00 should result in a valid fetch window of 6:25 pm to midnight but instead results in no time at all since the end time is before the start time.

The workaround is to enter: 18:25-23:59,00:00-06:00

This is confusing and counter intuitive.

image

https://jira.hic.dundee.ac.uk/browse/RDMPSUP-128

jas88 commented 2 years ago

For the simple overnight case (eg 18:00-06:00) inverting the logic if end is before start make sense (ie interpret it as 'do not run between 6am and 6pm'). Whether we regard 00:00 as the beginning or end of the day is a slightly trickier issue: how would you depict "6pm to midnight"? 18:00-23:59 is probably closest, 18:00-00:00 backfires badly for the unwary.

If you've ever configured Windows/AD user account logon time restrictions, there's a GUI indicator for those - maybe something like that would help here too?