search

HiddenRamblings / TagMo

GNU General Public License v3.0
3.01k stars 384 forks source link

master2 branch App crash due to Collections.sort #183

Closed zxavier94 closed 3 years ago

zxavier94 commented 4 years ago

com.hiddenramblings.tagmo.BrowserAmiibosAdapter.AmiiboFilter#publishResults Collections.sort((ArrayList) filterResults.values, new AmiiboComparator()); this line code cause the App crash

zxavier94 commented 4 years ago

android phone: redmi note 8 pro os: android 9

Eldin-Bridge commented 4 years ago

In which program did you check it?

zxavier94 commented 4 years ago

In which program did you check it? I download release 2.7.0 and install on my phone.When I open the app and click the load tag to search amiibo bin file,the app always crash.so, I pull the master2 branch to local，and use android studio build, and debug the app.Finally,I find the problem code.After I comment the code , and build the app, the app can run normally.

Eldin-Bridge commented 4 years ago

Excellent, if you can support that this program can improve, contact the manager to upload a review of the problems that you correct, I haven't had time for now but when I can I will try to help, all good intention thanks, if it doesn't bother you and you want to support non-profit go ahead

zxavier94 commented 4 years ago

Excellent, if you can support that this program can improve, contact the manager to upload a review of the problems that you correct, I haven't had time for now but when I can I will try to help, all good intention thanks, if it doesn't bother you and you want to support non-profit go ahead

Thank you!I am a gamer.These days i like Animal crossing,so I'll be glad to help others.I will try to fix the problem tomorrow or on this saturday,then i will contact the manager and push the code.

zxavier94 commented 4 years ago

Sorry,I have token 2 hours to try to fix the problem,but i failed.I change the way of reading the Amiibo.json file. QQ截图20200424215835 I let the app read Amiibo,json from External Files Dir,because the app can't read file from the root path,then i comment the Collections.sort code. QQ截图20200424215848 Finally,the app can run normally.I don't know why,the com.hiddenramblings.tagmo.BrowserActivity file is really complicated.

AbandonedCart commented 3 years ago

This should be resolved in the newest versions, but please feel free to comment back if this issue needs to be opened again.