HiddenRamblings / TagMo

GNU General Public License v3.0
2.99k stars 385 forks source link

New amiibo not appearing with photos #735

Closed AbandonedCart closed 1 week ago

AbandonedCart commented 1 week ago

Continuation of https://github.com/N3evin/AmiiboAPI/issues/181

N3evin commented 1 week ago

Are the other data populated? And just images?

AbandonedCart commented 1 week ago

Images are pulled from the API. There is a local database copy that’s superseded by the API if the API is newer.

N3evin commented 1 week ago

Anyway to debug the image url you are getting? From the APIs I can see that the image url is working.

AbandonedCart commented 1 week ago

I’m wondering if the issue is that it was synced when I had 3 of the image names wrong. It lines up with the issue. I think clearing the cache in TagMo would fix it.

N3evin commented 1 week ago

That could be it. Give that a try.

AbandonedCart commented 1 week ago

@Brickleberry19 Try going into settings and using the option to clear the database cache.

AbandonedCart commented 1 week ago

I’ve also triggered a fresh build with all the updates, so that will also fix it (since cache files should be name-based).

Brickleberry19 commented 1 week ago

@Brickleberry19 Try going into settings and using the option to clear the database cache.

Yea i did it and it doesnt fix it

AbandonedCart commented 1 week ago

You can also try refreshing the database from the same menu (it's labeled sync) or wait for the new update to do it automatically.

N3evin commented 1 week ago

I decided to install tagmo. Same issue even with sync. Installed from play store. Shall try with the apk build

Edit: same issue even with latest release from GitHub

N3evin commented 1 week ago

@Brickleberry19 mind telling me the key id? I believe that's the issue. The one I downloaded had 08020000 instead of 08020200 for Marie. Fake bin is going around.

Brickleberry19 commented 1 week ago

@Brickleberry19 mind telling me the key id? I believe that's the issue. The one I downloaded had 08020000 instead of 08020200 for Marie. Fake bin is going around.

Marie 0802000004370402

Callie 0801000004360402

Pearl 0803000004380402

Marina 0804000004390402

These are from the real amiibo , i scanned Them myself

N3evin commented 1 week ago

If that's the case the data that @AbandonedCart provided to amiiboapi is spoof data.

N3evin commented 1 week ago

I will update it tomorrow morning. Will need more verification if it's the correct data.

AbandonedCart commented 1 week ago

If that's the case the data that @AbandonedCart provided to amiiboapi is spoof data.

Or a typo...

AbandonedCart commented 1 week ago

@Brickleberry19 And you're absolutely sure they are entered correctly in your post? This is why I asked for verification and didn't want to move forward with the PR until it was confirmed.

Brickleberry19 commented 1 week ago

@Brickleberry19 And you're absolutely sure they are entered correctly in your post? This is why I asked for verification and didn't want to move forward with the PR until it was confirmed.

I am 100% Sure, i scanned the amiibo With your App Screenshot it and copied the ID via Google lens but i will Check it

AbandonedCart commented 1 week ago

I think whoever sent them to me typed them manually and may have introduced the typos by mistake. Spoof data typically zeroes out values, not introduces them. Considering there were three of us looking at them and it took this long to notice...

Either way, I think I need to add an easier method to retrieve the ID. There is no reason it should be that unreliable.

AbandonedCart commented 1 week ago

They should now be fixed in TagMo. Next build will have an option in the share / export to copy the ID. PR submitted to @N3evin to fix the API. It's still way ahead of the usual schedule for new additions, so this was just a friendly reminder of how every single digit counts.

AbandonedCart commented 1 week ago

Copy option still needs work. Seems I have it exporting the serial. That's not useful.

@Brickleberry19 Why do I keep forgetting to add you as co-author? You are a vital part of the process and your help is greatly appreciated.

AbandonedCart commented 1 week ago

Marie - 0802000004370402

Alright. It copies the ID correctly now.

Brickleberry19 commented 1 week ago

Thank you for this Update , Its a great Feature

Brickleberry19 commented 1 week ago

Copy option still needs work. Seems I have it exporting the serial. That's not useful.

@Brickleberry19 Why do I keep forgetting to add you as co-author? You are a vital part of the process and your help is greatly appreciated.

I don't really care if you add me as a co-author or not🤷🏻‍♂️😅

AbandonedCart commented 1 week ago

Yeah, but it’s deserved. You were doing twice the work you should because TagMo lacked such an obvious feature.

Brickleberry19 commented 1 week ago

Taking a screenshot and copying the ID from it is not that difficult and takes less than 10 seconds

Brickleberry19 commented 1 week ago

Thank you anyway for adding the option and for continuing to work on the app. You are doing a good job