Implement in-page navigation to sections in main - Githubissues

HidemichiShimura / old-portfolio

My personal portfolio website

https://hidemichi-shimura.vercel.app/

0 stars 0 forks source link

Implement in-page navigation to sections in main #36

Closed HidemichiShimura closed 1 year ago

HidemichiShimura commented 1 year ago

Proposed Changes

Code changes

Added id props to <SectionLayout />
Replaced margin-top units rem with px

Issues affected

Resolves #35

Additional Info

The Intro section does not contain and its id is hard coded, which needs to be fixed as well soon

Screenshots and/or video

I created dummy sections with corresponding ids of each section to demonstrate the in-page navigation

in-page-navigation

Testing Plan

Create dummy sections that are made of <SectionLayout /> with ids and check the navigation in the development server

Checklist

Basics

[x] Local QA is complete
[x] No debugging console.log() statements
[x] Commented-out code removed
[x] Unused code removed (imports, functions, styles, etc - if it's not used anywhere, it's not in this PR)