Hidendra / Plugin-Metrics

Metrics tools designed for minecraft plugins to gather statistical data
http://mcstats.org
85 stars 79 forks source link

Plugin performed restricted action. #52

Open SilverCory opened 10 years ago

SilverCory commented 10 years ago

I use the metrics in my plugin. And I was wondering if you could patch the Bungee plugin.

Bungeecord requests that instead of doing "new Thread()", you should use the Bungee scheduler.

Here is a stacktrace: 13:58:16 [WARNING] Plugin performed restricted action, please inform them to use proper API methods: Illegal thread group access java.security.AccessControlException: Plugin violation: Illegal thread group access at net.md_5.bungee.BungeeSecurityManager.checkRestricted(BungeeSecurityManager.java:39) at net.md_5.bungee.BungeeSecurityManager.checkAccess(BungeeSecurityManager.java:62) at java.lang.ThreadGroup.checkAccess(ThreadGroup.java:315) at java.lang.Thread.init(Thread.java:389) at java.lang.Thread.init(Thread.java:349) at java.lang.Thread.<init>(Thread.java:547) at eu.ac3_servers.dev.bvotifier.bungee.Metrics.start(Metrics.java:205) at eu.ac3_servers.dev.bvotifier.bungee.BVotifier.onEnable(BVotifier.java:69) at net.md_5.bungee.api.plugin.PluginManager.enablePlugins(PluginManager.java:207) at net.md_5.bungee.BungeeCord.start(BungeeCord.java:230) at net.md_5.bungee.Bootstrap.main(Bootstrap.java:65)

Link to the issue: https://bitbucket.org/acecheesecr14/bvotifier/issue/1/javasecurityaccesscontrolexception-plugin

turt2live commented 10 years ago

I would argue that the Bungee commit that implemented this is a dumb change and should be resolved by them for their idiotic waste of time.

SilverCory commented 10 years ago

Okay, well it's there and I doubt it's going to be removed for one java class.

Other plugins adapt, if this plugin doesn't then it's a feature I can't use and mcstats will be useless to me!

XxCoolGamesxX commented 10 years ago

More info of the error can look on the https://github.com/Minecrell/ServerListPlus/issues/23 of the Bungee Plugin Metrics.

stephan-gh commented 10 years ago

@XxCoolGamesxX Well I use my own Plugin-Metrics implementation on BungeeCord so you can't use the fix of my issue for this one. The BungeeCord version here should be rewritten to use the BungeeCord scheduler (similar to the Bukkit version) instead of using threads directly. (Additionally #40 should be probably merged..)

For anyone interested, here is my own Plugin-Metrics implementation for BungeeCord: Minecrell/BungeeMetrics - it works a bit different to the versions here but won't warn about the thread creations.

XxCoolGamesxX commented 10 years ago

@Minecrell Thanks for the info :P It help the devs. :P

SilverCory commented 10 years ago

@Minecrell brilliant. You beast ;P

stephan-gh commented 10 years ago

@acecheese You should keep it open until it is fixed anyway. ;)

SilverCory commented 10 years ago

@minecrell Point!