search

Higginbottom / pluto

This is a repository to track versions of Pluto made by Nick Higginbottom in the attempt to model disk winds
GNU General Public License v2.0
2 stars 3 forks source link

isothermal disk model failing #2

Closed kslong closed 6 years ago

kslong commented 6 years ago

The isothermal disk model is failing both with gcc and mpicc at the start of the run with a NAN on the blondin43 branch, see:

foo.txt

saultyevil commented 6 years ago

Same issue for me. There are some warnings related to pointers when compiling init.c, e.g.

init.c:162:6: warning: incompatible pointer types assigning to 'double *' from 'double *[3]' [-Wincompatible-pointer-types]
  x1 = grid[IDIR].x;

Could this be a potential cause of the problem?

jhmatthews commented 6 years ago

Think those pointers changed between 4.2 and 4.3 - I guess that’s probably it.

Higginbottom commented 6 years ago

Exactly right - I have updated the isothermal init.c file - not sure why the wrong one is in the repo…

Will fix...

On 14 Nov 2018, at 17:14, James Matthews notifications@github.com wrote:

Think those pointers changed between 4.2 and 4.3 - I guess that’s probably it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Higginbottom/pluto/issues/2#issuecomment-438742554, or mute the thread https://github.com/notifications/unsubscribe-auth/ADLMvUjgSkciSlRF-FfgPCmC6vJ3zr3lks5uvE96gaJpZM4YeCtc.

Higginbottom commented 6 years ago

Right - I forgot to push the change! fixed now…

On 14 Nov 2018, at 17:14, James Matthews notifications@github.com wrote:

Think those pointers changed between 4.2 and 4.3 - I guess that’s probably it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Higginbottom/pluto/issues/2#issuecomment-438742554, or mute the thread https://github.com/notifications/unsubscribe-auth/ADLMvUjgSkciSlRF-FfgPCmC6vJ3zr3lks5uvE96gaJpZM4YeCtc.

kslong commented 6 years ago

Yep. Works for me now, so I am closing the issue. Thanks, everyone.