search

HighDimensionalEconLab / DifferentiableStateSpaceModels.jl

MIT License
46 stars 1 forks source link

Investigate and remove SymbolicUtils pinning #105

Closed jlperla closed 2 years ago

jlperla commented 2 years ago

Some change in SymbolicUtils after 0.19.2 caused a regression. Investigate and remove the pinning.

wupeifan commented 2 years ago

Let me provide some details (if beneficial): from the last experiments that I ran, SymbolicUtils 0.19.8 spit out some errors in building the DSGE model from the source file. Therefore it has to be something in between.

jlperla commented 2 years ago

I isolated it and think it highly likely to be the same as https://github.com/JuliaSymbolics/SymbolicUtils.jl/issues/433

jlperla commented 2 years ago

If we end up need this, we might be able to replace the powers of 2 with 2.0. Otherwise we can wait for it to be closed.

jlperla commented 2 years ago

Alas, moving 1-> 1.0, 2 -> 2.0 didn't seem to provide a workaround so we will have to wait for the bug to be fixed in https://github.com/JuliaAlgebra/DynamicPolynomials.jl