search

HighDimensionalEconLab / DifferentiableStateSpaceModels.jl

MIT License
46 stars 1 forks source link

Decouple DifferenceEquations dependency #89

Closed wupeifan closed 2 years ago

wupeifan commented 2 years ago

The simulation should be downstream.

codecov[bot] commented 2 years ago

Codecov Report

Merging #89 (147aa93) into main (2fb8479) will increase coverage by 0.10%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   72.23%   72.33%   +0.10%     
==========================================
  Files          12       12              
  Lines        1138     1135       -3     
==========================================
- Hits          822      821       -1     
+ Misses        316      314       -2
Impacted Files Coverage Δ
src/sequence.jl 22.64% <ø> (-0.15%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2fb8479...147aa93. Read the comment docs.

wupeifan commented 2 years ago

The downstream simulation and gradients should pass now with https://github.com/SciML/DifferenceEquations.jl/pull/17. But don't merge yet!

wupeifan commented 2 years ago

After a review (and possibly merge later) of SciML/DifferenceEquations.jl#17, I'll add the tests back here and we can merge this one afterward.