Before we do our final changes, lets cleanup and rearrange our scripts area so it only has the minimal amount of code required for things actually in the paper. We also should (1) rename things so they are easy to follow and (2) ensure there is a clean separation between running the code and generating the figures if we expect these to happen separately.
The biggest change here is that we will remove the FVGQ replication, which might make things a little cleaner. I think we can remove the following at the very least:
After that, lets rename and reorganize things to be a little bit clearer for the replication, with more coming in the next issue.
Is there any reason we can't just put all of the scripts which do runs in a single folder called run_samplers? That way you could have a simple location where you generate everything into the .experiments or wherever you need it to be, and can call them all together or one at a time. If so,
[x] The https://github.com/HighDimensionalEconLab/HMCExamples.jl/tree/main/scripts/julia_replication folder is the rbc stuff, right? If so then lets rename these files to be have a rbc_ or something like that, which will ensure they are clearly different. Then move them into a main folder.
Right now things are a little confusing on where the plots and tables are generated. Lets reorganize things a little as well.
[x] Maybe have a folder generate_figures_tables which assumes that everything else has been run (or moved) into the .experiments folder
That folder would have the special project/manifest in it which is for plotting and not execution.
[ ] Lets standardized on the names for the table and figure generation for the baseline cases.
[ ] Lets also standardize on the basic name for the generation of results from the experiments to be consistent. Right now we have statplots.jl, sumstats_dynare.py and sumstats_julia.py which I think we can rename as sgu_figures.jl and sgu_tables.py etc. to be consistent. Then something a little different for the frequentist stuff and robustness.
Before we do our final changes, lets cleanup and rearrange our scripts area so it only has the minimal amount of code required for things actually in the paper. We also should (1) rename things so they are easy to follow and (2) ensure there is a clean separation between running the code and generating the figures if we expect these to happen separately.
The biggest change here is that we will remove the FVGQ replication, which might make things a little cleaner. I think we can remove the following at the very least:
After that, lets rename and reorganize things to be a little bit clearer for the replication, with more coming in the next issue.
Is there any reason we can't just put all of the scripts which do runs in a single folder called
run_samplers
? That way you could have a simple location where you generate everything into the.experiments
or wherever you need it to be, and can call them all together or one at a time. If so,https://github.com/HighDimensionalEconLab/HMCExamples.jl/tree/main/scripts/julia_replication
folder is therbc
stuff, right? If so then lets rename these files to be have arbc_
or something like that, which will ensure they are clearly different. Then move them into a main folder.rbc_run_samplers.sh
, which could replace the name of https://github.com/HighDimensionalEconLab/HMCExamples.jl/blob/main/scripts/julia_replication/tables.shrbc_sv_2
, right? If so, then we should call that sectionrbc_sv_replication
run.sh
in thesgu_replication
and therbc_sv_replication
.rbc_run_samplers.sh
, which could replace the name of https://github.com/HighDimensionalEconLab/HMCExamples.jl/blob/main/scripts/julia_replication/tables.sh if you think that makes sense.sgu
in https://github.com/HighDimensionalEconLab/HMCExamples.jl/blob/main/scripts/sgu_replication/run.sh which becomessgu_run_samples.sh
etc.echo
text in https://github.com/HighDimensionalEconLab/HMCExamples.jl/blob/main/scripts/julia_replication/tables.sh#L5 with something saying what the run itself is. The tables are generated somewhere else.Right now things are a little confusing on where the plots and tables are generated. Lets reorganize things a little as well.
generate_figures_tables
which assumes that everything else has been run (or moved) into the.experiments
folderstatplots.jl, sumstats_dynare.py
andsumstats_julia.py
which I think we can rename assgu_figures.jl
andsgu_tables.py
etc. to be consistent. Then something a little different for the frequentist stuff and robustness.