search

HighTechnologyFoundation / UFS2ARCO

NOAA ERA5 variable comparison to GEFvs13 variables
Apache License 2.0
0 stars 1 forks source link

I set up a skeleton python project with python's setuptools and tox. #6

Closed leldr closed 1 year ago

leldr commented 1 year ago

Close #1

HTFWitt commented 1 year ago

.gitignore files at all major levels .rst -> .md for documentation remove 'static' directory create a template.py file that has standard header info and initial structure

frolovsa commented 1 year ago

Thank you @leldr for putting the first PR together. Not sure how many PRs you have under your belt. It took me a while to get used to direct feedback on my code :)

I will let @HTFWitt and @timothyas contribute on technical details.

My main contribution is about the scope of this repo

I wonder if we want to have a more descriptive name for this effort. E.g. we probably dont want to mention era5 here. The crux of this repo is about converting UFS netcdf archives to zarr. maybe we can just name this repo ufs2zarr or ufs2cnard (i think cloud native analysis ready is a valid acronym?).

Not sure if we can change the repo name at this point. I am ok starting over and manually moving issues if needed.

Another tip is to tag us for review of this PR (top left corner). This will send us an email that will bug us to review.

Final thought., we might want to reflect the scope of this repo in the readme file. e.g. "tools and utilities to convert UFS native model output to cloud native analysis ready formats."

timothyas commented 1 year ago

Hi @leldr, thank you for kicking this off! I'll have some more detailed comments in a bit but first I wanted to try building the docs locally and I'm wondering if you have an environment file for the documentation? More generally, what do you use to manage packages in python? I have a lot of experience using conda.