search

Highjhacker / Ark-Elixir

Ark API Wrapper in Elixir
MIT License
11 stars 0 forks source link

Ark elixir testing #3

Closed Highjhacker closed 6 years ago

nathanjohnson320 commented 6 years ago

Can you add typespecs to these functions? They help a lot in the documentation and are extremely helpful when used with dialyxir https://hexdocs.pm/elixir/typespecs.html

insanedefaults commented 6 years ago

I'd be happy to go through and add typespecs. Small quality of life boost that's actually really helpful. I'll get to work on it. The first push probably won't be the entire thing typespec'd out, but even that shouldn't be that hard to do.

insanedefaults commented 6 years ago

Initial run at typespecs in #4. Not all modules are spec'd in yet, it's more for discussion to see if y'all want to proceed in this manner.

Highjhacker commented 6 years ago

Merged and added all the new changes to the testing branch ! Good work guys :D It's really neat.

So I guess we're close to the end of the work (for this new version (1.3)), and for the next one we can see what we can do (Async requests ? Streams ?), maybe gonna add a timeout for the requests on the dev network right now, cause from one day to an other, the peer can be sluggish.