search

HighlanderLab / SIMplyBee

SIMplyBee R package extends AlphaSimR for simulating honeybee populations and breeding programmes
http://www.simplybee.info/
Other
0 stars 5 forks source link

Provide PNG/... in addition to PDF for event images #489

Closed gregorgorjanc closed 1 year ago

gregorgorjanc commented 1 year ago

@LStrachan I think we will need PNG (or other graphics file format) in addition to PDF for the images - so that they can appear in the vignettes in the HTML format as there will be displayed in pkgdown (I think PDF won't work).

janaobsteter commented 1 year ago

For now, pdf works well in vignettes :)

gregorgorjanc commented 1 year ago

You mean in PDF vignette, but what about HTML vignette. Does it display the imported/included image in the HTML printout?

janaobsteter commented 1 year ago

For me it writes: "Couldn't load plugin" - but since they work in the pdf, I thought that was on my side?

gregorgorjanc commented 1 year ago

The same on my side

With regards, Gregor

On Fri, Dec 9 2022 at 7:37 am, janaobsteter @.***> wrote:

For me it writes: "Couldn't load plugin" - but since they work in the pdf, I thought that was on my side?

— Reply to this email directly, view it on GitHub https://github.com/HighlanderLab/SIMplyBee/issues/489#issuecomment-1343957156, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFRGSUUMGONARYZ7SQK2KTWMLOSVANCNFSM6AAAAAASYTFBQM . You are receiving this because you authored the thread.Message ID: @.***>

janaobsteter commented 1 year ago

Ok, let me try converting them to png and rerunning with that

janaobsteter commented 1 year ago

Ok, pngs work! I'll add them in and put the pdfs into .Rbuildignore. @gregorgorjanc , is it ok if I push them to the current PR (#488) or wait for you to merge than one?

janaobsteter commented 1 year ago

Ok, I've created pngs in put them in vignettes/figures/ instead of man/figures. But now the check doesn't work? @gregorgorjanc , do you know what could be wrong? image

janaobsteter commented 1 year ago

And this only happens in the "rebuilding vignettes" step

gregorgorjanc commented 1 year ago

your call - I am travelling till Wednesday so you will have to manage merges;)

With regards, Gregor

On Fri, Dec 09, 2022 at 09:40:58, janaobsteter @.***> wrote:

Ok, pngs work! I'll add them in and put the pdfs into .Rbuildignore. @ gregorgorjanc https://github.com/gregorgorjanc , is it ok if I push them to the current PR (#488 https://github.com/HighlanderLab/SIMplyBee/pull/488) or wait for you to merge than one?

— Reply to this email directly, view it on GitHub https://github.com/HighlanderLab/SIMplyBee/issues/489#issuecomment-1344078391, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFRGSUGV2TWP6BJVG6CQDDWML5CVANCNFSM6AAAAAASYTFBQM . You are receiving this because you were mentioned.Message ID: @.***>

janaobsteter commented 1 year ago

This is done and merged in