search

HighlanderLab / SIMplyBee

SIMplyBee R package extends AlphaSimR for simulating honeybee populations and breeding programmes
http://www.simplybee.info/
Other
0 stars 5 forks source link

added setMisc and getMisc #579

Closed gaynorr closed 1 month ago

gaynorr commented 4 months ago

The misc is slot is getting reworked in the new version of AlphaSimR and it will break SIMplyBee.

I added versions of setMisc and getMisc here that should work with both the new and old versions of AlphaSimR.

However, this doesn't completely fix the problem since there are several places where SIMplyBee pulls form the slots directly. These will have to be reworked. I suggest trying to rework them by rerouting through setMisc and getMisc so that the code will be robust to the AlphaSimR version.

gaynorr commented 4 months ago

See #578

gaynorr commented 4 months ago

@gregorgorjanc, I've made several changes to attempt to get the package to work with both the current version of AlphaSimR and the devel version with the changes to the misc slot.

I think everything should work against the current AlphaSImR version and you should get speed ups to getMisc and setMisc proposed by @LoupPiedfer in gaynorr/AlphaSimR#107.

The code isn't working for the devel version yet. I've only made some very quick changes and everything was working against your unit tests. However, I seeing one of the examples fail.