search

HikariKnight / material-awesome

Material and Mouse driven config for AwesomeWM 4.3
MIT License
126 stars 52 forks source link

Fix bug on panel creation with new awesome version #26

Closed lyghtnox closed 2 years ago

lyghtnox commented 2 years ago

Hi,

Because of a change in recent versions of lua, require now returns 2 values instead of 1. This creates some issues with your config (#25).

I used the information on this thread to fix this. I tested it and it works fine (at least on my system) with the last version of the awesome-git AUR package.

HikariKnight commented 2 years ago

i will give this a test on a system with older lua, since i use pop os, not arch 😄 and i do not want to break it on non arch systems ;)

HikariKnight commented 2 years ago

hey @lyghtnox this ends up breaking on lua5.3 which the majority of distros use. for the time being i guess the best would be for me to create a lua5.4 branch that you can send the pull request to and i will mention it in the readme.md, unless we can find a way to support both somehow.

shall i make a lua5.4 branch for future transition?

lyghtnox commented 2 years ago

Well I am not knowledgeable enough in lua to support both 5.3 and 5.4 ^^ Creating a new branch to support 5.4 seems to be the best option for now

HikariKnight commented 2 years ago

new branch made https://github.com/HikariKnight/material-awesome/tree/lua5.4