search

Hildaware / Hilda

Hilda is a plugin for Dalamud in conjunction with XIVLauncher with an aim to teach players how to play combat Jobs with very little prior knowledge.
https://hildaware.github.io/Hilda/
26 stars 1 forks source link

Multi-target hit detection appears to detect friendly NPCs in some cases. #7

Open nckzvth opened 2 months ago

nckzvth commented 2 months ago

Describe the bug While completing the level 70 warrior quest, the two NPCs that you fight with were detected by Hilda. This caused the plugin to switch to the multi-target priority, even though there was only one enemy to hit. This leads me to believe that it may also happen in similar scenarios like the duty support queue.

To Reproduce Steps to reproduce the behavior:

  1. Start the last phase of the level 70 warrior quest.
  2. While Main is toggled on, the plugin will detect the two friendly NPCs.
  3. See error

Expected behavior The plugin should not detect NPCs that cannot be hit during an encounter.

Screenshots image

bferrari352 commented 2 months ago

Hey, thanks for reporting this! Dalamud made some changes recently to the structure of GameObjects, and we didn't follow up on if it was working properly. Clearly it was not.

I've nailed down a fix so it will be in the next bug fix version.

jcql commented 2 months ago

We reproduced this in some fates, hopefully fixed in 7.0.0.1 -- let us know!

nckzvth commented 2 months ago

I will be testing more over the weekend and will definitely reach out with additional feedback.