Hillcrest-R-D / FORM

F# Object Relational Mapper
MIT License
15 stars 0 forks source link

Utilities escape function requires user to box input #33

Open mflibby opened 5 months ago

mflibby commented 5 months ago

Nearly a nit, but Form.Utilities.escape requires that the list of inputs (which will generally be strings) currently requires that they be interpreted as obj on input, i.e. a selectWhere call is like:

let x = "some cool filter string"

selectWhere<SomeType> state None ("myColumn = ':1'", [box x])

Now this isn't a huge hassle, as the compiler will do a lot of the boxing for us as long as we have boxed one of the string inputs (given the whole single type list thing), but we should try and find a way around this as it is really a pain point.