search

HilliamT / Vapor-Authenticator

Desktop Authenticator for Steam for players, traders and gamers to be able to utilise, facilitate and automate Steam from their desktop
MIT License
31 stars 9 forks source link

Adding accept all tradeoffers button #12

Closed rchutzz closed 1 year ago

rchutzz commented 1 year ago

Hello,

I had issues with confirmations not loading because of steam authentication issues.

  1. Resolved by updating npm update steamcommunity
  2. Added border/ width of size 12 to the renderConfirmations steam avatar to prevent it from overflowing
  3. Added a button Accept All to accept all trade confirmations.

For people who sell a lot of items on buff.163 or other marketplaces, this will allow users to automate accepting tons of confirmations at once (3 second delay that waits for promise to resolve). might need to add disclaimer if the user's api trade url has been compromised by the apiscam

Screen Shot 2023-07-09 at 5 42 43 PM

also, I do not know how to get around the dependency issue when trying to merge this branch with the master. when I run npm install steamcommunity, it updates the package-lock.json and all related dependencies which doesn't pass the test. however, it runs locally with npm start and npm run build.

any advice how to resolve the issue?

Copy-link commented 1 year ago

If this doesn't work, try just pushing the Confirmations.tsx changes in the commit and not the other files.

rchutzz commented 1 year ago

Hey! That makes sense, but for some reason, getAllConfirmations was not working for me (i.e. confirmations not rendering) without updating some dependencies. GitHub test_pull_request kept failing because mail.yml was running npm run build with v10.x which had incompatibility issues. I submitted two new pull requests to adjust the change node version to use v14.x which prevents the tailwindcss issue. Hopefully that will allow me to push my branch without failing the tests. Waiting for someone to look over it.

On Mon, Jul 10, 2023 at 2:49 PM ImportTaste @.***> wrote:

If this doesn't work, try just pushing the Confirmations.tsx changes in the commit and not the other files.

— Reply to this email directly, view it on GitHub https://github.com/HilliamT/Vapor-Authenticator/pull/12#issuecomment-1629777632, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIB75YZMKMB26VO3FPV7YILXPR2GHANCNFSM6AAAAAA2FDVP5Y . You are receiving this because you authored the thread.Message ID: @.***>

--

-- Cheers, Richard Hai